bug report, Weka GUI Chooser exiting ImageJ2

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

bug report, Weka GUI Chooser exiting ImageJ2

Christian Rickert
Hello, hope everyone is well.

I've noticed a bug with the Weka GUI Chooser that I'd like to report:

Bug:   Exiting the Weka GUI Chooser started by the Trainable Weka Segmentation Plugin in ImageJ2
           exits ImageJ2 and all open files instead of the Weka GUI Chooser window only

Example:
'''
// open the ImageJ2 Interactive Interpreter (CTRL+J)
// and run a copy of this code (CTRL+R)
run("Blobs (25K)");
run("Trainable Weka Segmentation");
selectWindow("Trainable Weka Segmentation v3.2.34");
call("trainableSegmentation.Weka_Segmentation.launchWeka");
'''

Description
The example code will open the Weka GUI Chooser window from the Trainable Weka Segmentation.
Interestingly, the close button from the Window itself is non-functional,
i.e. the window doesn't close and can't be closed without restarting ImageJ2.
If you now want to exit this window(CTRL+E, see "program_exit.png"), you'll get a confirmation dialog,
prompting you to close "this window" (see "exit_confirmation.PNG").
However, this will acutally exit ImageJ2 without further confirmation!

Expected behaviour:
The Weka GUI Chooser window should close, when exiting (command) or closing (clicking) the window.

Versions:
Microsoft Windows [Version 10.0.19042.685]
ImageJ 2,  1.53g with Java 1.8.0_172 (64-bit)
Trainable Weka Segmentation 3.2.34
Weka GUI Chooser 3.9.4

Is this a Weka GUI Chooser issue (calling a global exit function) or a Trainable Weka Segmentation issue
(forwarding the local exit function call) or perhaps a combination of the two?

Best regards,
Christian Rickert

_______________________________________________
Wekalist mailing list -- [hidden email]
Send posts to [hidden email]
To unsubscribe send an email to [hidden email]
To subscribe, unsubscribe, etc., visit https://list.waikato.ac.nz/postorius/lists/wekalist.list.waikato.ac.nz
List etiquette: http://www.cs.waikato.ac.nz/~ml/weka/mailinglist_etiquette.html
Reply | Threaded
Open this post in threaded view
|

Re: bug report, Weka GUI Chooser exiting ImageJ2

Michael Hall


> On Dec 28, 2020, at 2:54 PM, Christian Rickert <[hidden email]> wrote:
>
> Hello, hope everyone is well.
>
> I've noticed a bug with the Weka GUI Chooser that I'd like to report:
>
> Bug:   Exiting the Weka GUI Chooser started by the Trainable Weka Segmentation Plugin in ImageJ2
>            exits ImageJ2 and all open files instead of the Weka GUI Chooser window only
>

Not a Weka developer but Weka doesn’t normally run as a plugin but as an application itself. It possibly issues System.exit(0); or similar to shut itself down but this probably shuts down everything including ImageJ2 in this case.

I wrote a java command line shell application that had to deal with that. I actually took my handling from another shell application at the time. JShell (Patrick Beard with Apple a while back, not the JDK JShell). It installs a SecurityManager that catches the System.exit request and kills the thread instead.

ImageJ2 would probably have to handle this in order to run code that issues System.exit(). Not a Weka bug.

Fwiw.
_______________________________________________
Wekalist mailing list -- [hidden email]
Send posts to [hidden email]
To unsubscribe send an email to [hidden email]
To subscribe, unsubscribe, etc., visit https://list.waikato.ac.nz/postorius/lists/wekalist.list.waikato.ac.nz
List etiquette: http://www.cs.waikato.ac.nz/~ml/weka/mailinglist_etiquette.html
Reply | Threaded
Open this post in threaded view
|

Re: bug report, Weka GUI Chooser exiting ImageJ2

Christian Rickert
Hi Michael,

Thanks for your input - I'm going to take this issue to the TWSP issue tracker.

Best regards,
Christ

On December 30, 2020 at 6:31 PM, Michael Hall <[hidden email]> wrote:



On Dec 28, 2020, at 2:54 PM, Christian Rickert <[hidden email]> wrote:

Hello, hope everyone is well.

I've noticed a bug with the Weka GUI Chooser that I'd like to report:

Bug: Exiting the Weka GUI Chooser started by the Trainable Weka Segmentation Plugin in ImageJ2
exits ImageJ2 and all open files instead of the Weka GUI Chooser window only


Not a Weka developer but Weka doesn’t normally run as a plugin but as an application itself. It possibly issues System.exit(0); or similar to shut itself down but this probably shuts down everything including ImageJ2 in this case.

I wrote a java command line shell application that had to deal with that. I actually took my handling from another shell application at the time. JShell (Patrick Beard with Apple a while back, not the JDK JShell). It installs a SecurityManager that catches the System.exit request and kills the thread instead.

ImageJ2 would probably have to handle this in order to run code that issues System.exit(). Not a Weka bug.

Fwiw.
_______________________________________________
Wekalist mailing list -- [hidden email]
Send posts to [hidden email]
To unsubscribe send an email to [hidden email]
To subscribe, unsubscribe, etc., visit https://list.waikato.ac.nz/postorius/lists/wekalist.list.waikato.ac.nz
List etiquette: http://www.cs.waikato.ac.nz/~ml/weka/mailinglist_etiquette.html

_______________________________________________
Wekalist mailing list -- [hidden email]
Send posts to [hidden email]
To unsubscribe send an email to [hidden email]
To subscribe, unsubscribe, etc., visit https://list.waikato.ac.nz/postorius/lists/wekalist.list.waikato.ac.nz
List etiquette: http://www.cs.waikato.ac.nz/~ml/weka/mailinglist_etiquette.html
Reply | Threaded
Open this post in threaded view
|

Re: bug report, Weka GUI Chooser exiting ImageJ2

Michael Hall


> On Jan 11, 2021, at 11:52 AM, Christian Rickert <[hidden email]> wrote:
>
> Hi Michael,
>
> Thanks for your input - I'm going to take this issue to the TWSP issue tracker.
>

I’m not sure what TWSP is. But again, I think if ImageJ2 is going to try and run arbitrary code as plugins they need to handle it if that code does a System.exit() somehow.
_______________________________________________
Wekalist mailing list -- [hidden email]
Send posts to [hidden email]
To unsubscribe send an email to [hidden email]
To subscribe, unsubscribe, etc., visit https://list.waikato.ac.nz/postorius/lists/wekalist.list.waikato.ac.nz
List etiquette: http://www.cs.waikato.ac.nz/~ml/weka/mailinglist_etiquette.html
Reply | Threaded
Open this post in threaded view
|

Re: bug report, Weka GUI Chooser exiting ImageJ2

Christian Rickert
I fully agree with you. Thanks again!

Chris

P.S.: TWSP  = Trainable Weka Segmentation plug-in (ImageJ2)
P.P.S. https://imagej.net/Trainable_Weka_Segmentation
---
Sent from my iPhone

On Jan 11, 2021, at 16:06, Michael Hall <[hidden email]> wrote:



On Jan 11, 2021, at 11:52 AM, Christian Rickert <[hidden email]> wrote:

Hi Michael,

Thanks for your input - I'm going to take this issue to the TWSP issue tracker.


I’m not sure what TWSP is. But again, I think if ImageJ2 is going to try and run arbitrary code as plugins they need to handle it if that code does a System.exit() somehow.
_______________________________________________
Wekalist mailing list -- [hidden email]
Send posts to [hidden email]
To unsubscribe send an email to [hidden email]
To subscribe, unsubscribe, etc., visit https://list.waikato.ac.nz/postorius/lists/wekalist.list.waikato.ac.nz
List etiquette: http://www.cs.waikato.ac.nz/~ml/weka/mailinglist_etiquette.html

_______________________________________________
Wekalist mailing list -- [hidden email]
Send posts to [hidden email]
To unsubscribe send an email to [hidden email]
To subscribe, unsubscribe, etc., visit https://list.waikato.ac.nz/postorius/lists/wekalist.list.waikato.ac.nz
List etiquette: http://www.cs.waikato.ac.nz/~ml/weka/mailinglist_etiquette.html